refactor: more intermediate output columns and input validation #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BainanXia
reviewed
Mar 3, 2020
powersimdata/scaling/clean_capacity_scaling/tests/test_object_persistence.py
Show resolved
Hide resolved
BainanXia
reviewed
Mar 3, 2020
powersimdata/scaling/clean_capacity_scaling/tests/test_target_manager_input.py
Outdated
Show resolved
Hide resolved
BainanXia
reviewed
Mar 3, 2020
powersimdata/scaling/clean_capacity_scaling/tests/test_target_manager_input.py
Outdated
Show resolved
Hide resolved
|
Integration test: it generates exactly same results with the previous code. Just need some pep8 cleanings and we are good to go. Good to see the corner cases are captured specifically. |
BainanXia
reviewed
Mar 3, 2020
| @@ -11,7 +14,8 @@ def test_create_targets_from_dataframe(): | |||
| 'ce_target_fraction': [.25, .4], | |||
| 'total_demand': [200000, 300000], | |||
| 'external_ce_historical_amount': [0, 0], | |||
| 'solar_percentage': [.3, .6]} | |||
| 'solar_percentage' :[.3, .6], | |||
There was a problem hiding this comment.
The space added at wrong place...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the capacity scaling framework up date with the latest changes.
The main changes are:
(1) code to adapt to the current format of the allowed resourced column
(2) additional columns of intermediate calculations added the next capacities dataframe
(3) input validation for capacity factors, etc.
(4) refinement of object JSON string output